SM feature by MykolaSuperman · Pull Request #11 · aosedge/aos_core_cpp

MykolaSuperman · 2025-06-17T12:12:31Z

No description provided.

al1img · 2025-06-23T12:37:31Z

src/sm/CMakeLists.txt

 # SPDX-License-Identifier: Apache-2.0
 #

-cmake_minimum_required(VERSION 3.19)


commit message:

sm: cmake:

al1img · 2025-06-23T13:22:00Z

src/sm/alerts/journalalerts.hpp


 #include <aos/common/cloudprotocol/cloudprotocol.hpp>
-#include <config/config.hpp>
+


Remove empty line in all the cases

al1img · 2025-06-23T13:22:44Z

src/sm/app/aoscore.cpp

@@ -23,7 +23,7 @@ void AosCore::Init(const std::string& configFile)
    auto err = mLogger.Init();
    AOS_ERROR_CHECK_AND_THROW(err, "can't initialize logger");



commit message:

sm: app: use...

al1img · 2025-06-23T13:23:06Z

src/sm/database/database.cpp

    return ErrorEnum::eNone;
 }

+Error Database::AddInstanceNetworkInfo(const sm::networkmanager::InstanceNetworkInfo& info)


commit message:

sm: database: implement....

al1img · 2025-06-23T13:23:32Z

src/sm/networkmanager/cni.cpp

 {
    LOG_DBG() << "Set CNI configuration directory: configDir=" << configDir.CStr();

-    mConfigDir = std::filesystem::path(configDir.CStr()) / "results";


commit message:

sm: cni: move...

al1img · 2025-06-23T13:24:40Z

src/sm/networkmanager/trafficmonitor.cpp


 Error TrafficMonitor::DeleteTrafficChain(const std::string& chain, const std::string& rootChain)
 {
+    if (chain.empty()) {


commit message:

sm: network: check...

al1img · 2025-06-23T13:25:47Z

src/sm/database/tests/database.cpp


 std::string GetMigrationSourceDir()
 {
-    std::filesystem::path curFilePath(__FILE__);


commit message:

sm: database: use macro...

al1img · 2025-06-23T13:26:17Z

src/sm/database/tests/database.cpp

-    std::filesystem::path migrationSourceDir = curFilePath.parent_path() / "../.." / "src/database/migration/";
-
-    return std::filesystem::canonical(migrationSourceDir).string();
+#ifndef DATABASE_MIGRATION_PATH


Where the macro is defined? It should be part of CONFIG_ I guess.

it defined in cmake file for this test

al1img · 2025-06-23T13:27:43Z

CMakeLists.txt


 add_subdirectory(${AOS_CORE_API_DIR} aos_core_api)
 add_subdirectory(${AOS_CORE_LIB_DIR}/src/common aos_core_lib/common)
+if(WITH_SM)


Add empty line before if

codecov · 2025-06-24T08:33:36Z

Codecov Report

Attention: Patch coverage is 83.52941% with 14 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@370706a). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
src/sm/database/database.cpp	75.75%	8 Missing ⚠️
src/sm/networkmanager/tests/mocks/storagemock.hpp	0.00%	3 Missing ⚠️
src/sm/app/aoscore.cpp	0.00%	1 Missing ⚠️
src/sm/app/app.cpp	0.00%	1 Missing ⚠️
src/sm/networkmanager/trafficmonitor.cpp	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             develop      #11   +/-   ##
==========================================
  Coverage           ?   78.47%           
==========================================
  Files              ?      193           
  Lines              ?    21088           
  Branches           ?     2037           
==========================================
  Hits               ?    16549           
  Misses             ?     4539           
  Partials           ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mlohvynenko · 2025-06-24T09:20:07Z

src/sm/smclient/CMakeLists.txt

+              Poco::Util
+)
+
+if(WITH_SM_API)


looks like a redundant condition: WITH_SM_API is set to ON if with_sm is set to ON

mykola-kobets-epam · 2025-06-24T10:27:10Z

src/sm/app/CMakeLists.txt

+    aoscommon
+    aossm
+    ${COMMON_NAMESPACE}::iamclient
+    ${COMMON_NAMESPACE}::jsonprovider


It was agreed to use aos::common:: explicitly

mykola-kobets-epam · 2025-06-24T10:28:03Z

src/sm/resourcemanager/CMakeLists.txt

 # ######################################################################################################################

-target_link_libraries(${TARGET} PUBLIC aosutils aoscommon Poco::JSON)
+set(LOG_MODULE_NAME resourcemanager)


LOG_MODULE_NAME is boolean & not required in this context

thanks, done

mlohvynenko

Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

al1img · 2025-06-24T12:24:21Z

Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

mykola-kobets-epam · 2025-06-24T12:25:56Z

Reviewed-by: Mykola Kobets <mykola_kobets@epam.com>

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

sonarqubecloud · 2025-06-24T13:41:18Z

Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

MykolaSuperman force-pushed the sm_feature branch from 0666ace to 47708ae Compare June 19, 2025 05:25

al1img reviewed Jun 23, 2025

View reviewed changes

MykolaSuperman force-pushed the sm_feature branch 2 times, most recently from 1f4104f to 79df765 Compare June 24, 2025 07:13

mlohvynenko reviewed Jun 24, 2025

View reviewed changes

mykola-kobets-epam approved these changes Jun 24, 2025

View reviewed changes

MykolaSuperman force-pushed the sm_feature branch from b146045 to 9af7052 Compare June 24, 2025 11:42

mlohvynenko approved these changes Jun 24, 2025

View reviewed changes

al1img approved these changes Jun 24, 2025

View reviewed changes

MykolaSuperman force-pushed the sm_feature branch from 9af7052 to 54fe703 Compare June 24, 2025 12:30

Mykola Solianko added 15 commits June 24, 2025 16:20

sm: rmove reduntant files

d10ce37

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

sm: cmake: use add module cmake functions

4ccc14e

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

sm: app: Use version macro from common

46712da

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

sm: database: Implement network instance table

34b1fde

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

sm: cni: Move create dir in call side

4ef115f

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

sm: network: Check chain on empty before delete

34ea5e6

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

sm: database: Use macro for migration path

f4dfb30

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

cmake: include core lib sm

200c9b8

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

cmake: include sm component

dc2fae9

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

sm: change header guards naming

400ba49

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

sm: fix cppcheck warnings

ea87a2c

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

MykolaSuperman force-pushed the sm_feature branch from 54fe703 to ea87a2c Compare June 24, 2025 13:22

al1img merged commit 472adc3 into aosedge:develop Jun 24, 2025
4 of 5 checks passed


		#include <aos/common/cloudprotocol/cloudprotocol.hpp>
		#include <config/config.hpp>

		@@ -23,7 +23,7 @@ void AosCore::Init(const std::string& configFile)
		auto err = mLogger.Init();
		AOS_ERROR_CHECK_AND_THROW(err, "can't initialize logger");

Conversation

MykolaSuperman commented Jun 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mlohvynenko left a comment

Choose a reason for hiding this comment

Uh oh!

al1img commented Jun 24, 2025

Uh oh!

mykola-kobets-epam commented Jun 24, 2025

Uh oh!

sonarqubecloud bot commented Jun 24, 2025

Quality Gate failed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jun 24, 2025 •

edited

Loading